Update README.md #2895
Open
Update README.md #2895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Xiangxu-0103
reviewed
Feb 2, 2024
| @@ -11,7 +11,7 @@ We follow the procedure in [votenet](https://github.com/facebookresearch/votenet | |||
| 4. Enter the project root directory, generate training data by running | |||
|
|
|||
| ```bash | |||
| python tools/create_data.py scannet --root-path ./data/scannet --out-dir ./data/scannet --extra-tag scannet | |||
| python tools/create_data.py --dataset scannet --root-path ./data/scannet --out-dir ./data/scannet --extra-tag scannet | |||
There was a problem hiding this comment.
It seems we do not need to add --dataset argument.
There was a problem hiding this comment.
I am not sure how you run this script, but on my end, when I run the script without the --dataset argument ( for scannet for example), I get the following error:
usage: create_data.py [-h] [--dataset kitti] [--root-path ROOT_PATH] [--version VERSION] [--max-sweeps MAX_SWEEPS] --out-dir OUT_DIR [--extra-tag EXTRA_TAG]
[--workers WORKERS]
create_data.py: error: unrecognized arguments: scannet
There was a problem hiding this comment.
I believe this line makes the script expecting the --dataset argument.
There was a problem hiding this comment.
I am using python 3.10 btw.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The command to run the
create_data.pyscript, does not run in shell.Modification
Proper arguments should be passed to the script.